![]() So actually your change seems to break this, or at least your change now causes behavior that breaks my expectations as a user. Looks like _.defaults doesn't override stuff, but _.assign behaves differently. but that seems completely broken, because now we have no way to override the rsync flags for special cases. Maybe I'm just missing something? I git blamed this line and there is a commit that implies that this is actually what the desired behavior is. I can get a PR with this change if there is consensus that this is indeed a bug. My Perl utility generates a bash script that consists of mkdir/rsync/cp commands. So, it seems like the order here should be swapped so that rsync is copied from nfig first, and options last, which would allow you to actually override the rsync behavior when you want to. 'copy' method is deprecated, please use 'copyToRemote', 'copyFromRemote', 'scpCopyToRemote' or 'scpCopyFromRemote'. So if I understand that correctly, we copy all properties from options, then override rsync and ignores with a value from nfig or (redundantly) options if is undefined. As rsync is listed in dependencies I would expected some error, but instead shipit uses tar: when no rsync is installed Copy project to remote servers. are provided for mirrors with independent rsync modules, so that admin of. Not only that, but it looks like, according to, _.assign will copy properties from the sources from left to right. wrap it with new covers &c and ship it, and the best package will win. Why should we obey nfig over the opts arguments that are passed in? Expected behavior is to be able to override rsync behavior when we need to by using the options argument. (Jeff Layton) 704921 - fs cifs: split posix open/mkdir from legacy mkdir in. In remoteCopy, will always be used, if it is specified. Remove bashbug from the documentation, because we dont ship it due to.
0 Comments
Leave a Reply. |